Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: non-100%-reproducible object files #31975

Closed
josharian opened this issue May 10, 2019 · 3 comments
Closed

cmd/compile: non-100%-reproducible object files #31975

josharian opened this issue May 10, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.13

Comments

@josharian
Copy link
Contributor

Observed by @dr2chase in CL 176577. I have reproduced locally using for f in seq 1000; do go build -o oserr -a internal/oserror; md5 oserr; done and noting occasional deviations.

I am bisecting now.
@josharian josharian added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels May 10, 2019
@josharian josharian added this to the Go1.13 milestone May 10, 2019
@josharian
Copy link
Contributor Author

Drat. Bisected to https://go-review.googlesource.com/c/go/+/170037, which was just when non-trivial code was added to internal/oserror. Will bisect again tomorrow.

@cuonglm
Copy link
Member

cuonglm commented May 11, 2019

@josharian Because https://go-review.googlesource.com/c/go/+/170037 added duplicated anonymous interface, causing build not 100% reproducible.

CL https://go-review.googlesource.com/c/go/+/162240/ tries to fix that problem, +2 but not merge yet.

@josharian
Copy link
Contributor Author

Looks like this is indeed a duplicate of #30202.

@josharian josharian mentioned this issue May 11, 2019
Closed
@golang golang locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
3 participants
@josharian @cuonglm @gopherbot