Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/modfetch: TestCodeRepo/parallel/gopkg.in_natefinch_lumberjack.v2/v2.1 failing at head #31965

Closed
bcmills opened this issue May 10, 2019 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented May 10, 2019

Likely another case of #28856, masked by #31263.

[…]
--- FAIL: TestCodeRepo (18.60s)
    --- FAIL: TestCodeRepo/parallel (0.00s)
        --- FAIL: TestCodeRepo/parallel/gopkg.in_natefinch_lumberjack.v2/v2.1 (3.35s)
            coderepo_test.go:386: info.Version = "v2.1.1-0.20170531160350-a96e63847dc3", want "v2.0.0-20170531160350-a96e63847dc3"
[…]
FAIL
FAIL    cmd/go/internal/modfetch        19.588s

CC @jayconrod

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels May 10, 2019
@bcmills bcmills added this to the Go1.13 milestone May 10, 2019
@bcmills bcmills self-assigned this May 10, 2019
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label May 10, 2019
@bcmills
Copy link
Contributor Author

bcmills commented May 10, 2019

I don't actually see any tagging changes that explain the failure. Will need to bisect.

@thepudds
Copy link
Contributor

thepudds commented May 10, 2019

coderepo_test.go:386: info.Version = "v2.1.1-0.20170531160350-a96e63847dc3", want "v2.0.0-20170531160350-a96e63847dc3"

Drive by comment: https://golang.org/cl/174061 or https://golang.org/cl/174206 spring to mind.

But is this an internal test that was passing previously with those changes already in place? (If so, then perhaps not them ;-)

That looks like a "want" non-pseudoversion is now a pseudoversion?

@bcmills
Copy link
Contributor Author

bcmills commented May 10, 2019

The base for the want pseudo-version went from v2.0.0 to v2.1.1.

I'm pretty sure I saw a couple pseudo-version changes go by while I was out, but I'm pretty sure git bisect will find it either way. 🙂

@thepudds
Copy link
Contributor

That commit seems to have an "almost semver" tag of v2.1:

https://github.com/natefinch/lumberjack/tree/v2.1

@thepudds
Copy link
Contributor

if semver.IsValid(semtag) {

I think semver.IsValid might accept something like v2.1 as valid?

Maybe that needs to be semtag == semver.Canonical(semtag), or something like that?

@bcmills
Copy link
Contributor Author

bcmills commented May 10, 2019

Ooh, that's a good find. Thank you!

@bcmills
Copy link
Contributor Author

bcmills commented May 10, 2019

git bisect points to CL 174061, which (as it turns out) is where that call to semver.IsValid was added.

@gopherbot
Copy link

Change https://golang.org/cl/176539 mentions this issue: cmd/go/internal/modfetch/codehost: ignore incomplete semver tags in RecentTag

@golang golang locked and limited conversation to collaborators May 12, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants