Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go version stopped getting added to go.mod #31960

Closed
rsc opened this issue May 10, 2019 · 3 comments
Closed

cmd/go: go version stopped getting added to go.mod #31960

rsc opened this issue May 10, 2019 · 3 comments
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.13

Comments

@rsc
Copy link
Contributor

rsc commented May 10, 2019

I ran some go build commands just now in a new module and there is not a go version in my go.mod. There should be.

/cc @bcmills @jayconrod
@rsc rsc added this to the Go1.13 milestone May 10, 2019
@bcmills
Copy link
Contributor

bcmills commented May 10, 2019

That was an intentional change in behavior for #30790.

We now add the go directive only in go mod init and go mod tidy

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label May 13, 2019
@bcmills
Copy link
Contributor

bcmills commented May 14, 2019

Per discussion with Russ, we should go with the alternative described in #30790 (comment): we should always write the go version if it isn't present.

@bcmills bcmills self-assigned this May 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/176925 mentions this issue: cmd/go: always add 'go' directive to the go.mod file if missing

@mark-rushakoff mark-rushakoff mentioned this issue May 28, 2019
Closed
mark-rushakoff added a commit to influxdata/influxdb that referenced this issue May 28, 2019
@mark-rushakoff
chore: add go directive to go.mod
881c27f 
As of golang/go#31960, go1.13 (or tip) will always add the go directive
to go.mod. Add it now as go 1.12 so that we don't have churn later as
people start using 1.13, before we're ready to officially switch to
building influxdb with 1.13.
@mark-rushakoff mark-rushakoff mentioned this issue May 28, 2019
Merged
mark-rushakoff added a commit to influxdata/influxdb that referenced this issue May 28, 2019
@mark-rushakoff
chore: add go directive to go.mod
43ffeb2 
As of golang/go#31960, go1.13 (or tip) will always add the go directive
to go.mod. Add it now as go 1.12 so that we don't have churn later as
people start using 1.13, before we're ready to officially switch to
building influxdb with 1.13.
mark-rushakoff added a commit to influxdata/influxdb that referenced this issue May 29, 2019
@mark-rushakoff
chore: add go directive to go.mod
3500580 
As of golang/go#31960, go1.13 (or tip) will always add the go directive
to go.mod. Add it now as go 1.12 so that we don't have churn later as
people start using 1.13, before we're ready to officially switch to
building influxdb with 1.13.
mark-rushakoff added a commit to influxdata/influxdb that referenced this issue May 29, 2019
@mark-rushakoff
chore: add go directive to go.mod
f904c92 
As of golang/go#31960, go1.13 (or tip) will always add the go directive
to go.mod. Add it now as go 1.12 so that we don't have churn later as
people start using 1.13, before we're ready to officially switch to
building influxdb with 1.13.
@bcmills bcmills mentioned this issue Jul 2, 2019
Closed
@golang golang locked and limited conversation to collaborators May 15, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
5 participants
@rsc @andybons @bcmills @gopherbot @thepudds