Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: misc-vet-vetall builder is fetching modules with a firewall and no module proxy? #31890

Closed
bradfitz opened this issue May 7, 2019 · 1 comment
Closed

x/build: misc-vet-vetall builder is fetching modules with a firewall and no module proxy? #31890

bradfitz opened this issue May 7, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented May 7, 2019

The misc-vet-vetall builder logs suggest it's downloading modules. That's fine, but it looks like it's firewalled off from making outbound connections (GO_DISABLE_OUTBOUND_NETWORK=1) but it doesn't have GOPROXY set to the 10.0.0.0/8 whitelisted range (it has nothing set instead, since we only do that for subrepos, and vetall is special).

I don't know how this is working today. Maybe the firewall stuff stopped working?

Or maybe the vetall container lacks the iptables binary? (the firewall is self-imposed)

Build log:
misc-vet-vetall at b32d75f59815491bf507249bde10e0842aef9209

:: Running /workdir/go/src/make.bash with args ["/workdir/go/src/make.bash"] and env ["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-jessie-rne84ee61" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=13.1s" "GO_STAGE0_DL_DELAY=100ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=misc-vet-vetall" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOBIN=" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/go/src

Building Go cmd/dist using /go1.4.
Building Go toolchain1 using /go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for linux/amd64.
---
Installed Go for linux/amd64 in /workdir/go
Installed commands in /workdir/go/bin

##### cmd/vet/all
go: finding golang.org/x/arch v0.0.0-20181203225421-5a4828bb7045
go: finding golang.org/x/tools v0.0.0-20190325223049-1d95b17f1b04
go: finding golang.org/x/sys v0.0.0-20190502175342-a43fa875dd82
go: finding github.com/ianlancetaylor/demangle v0.0.0-20180524225900-fc6590592b44
go: finding golang.org/x/crypto v0.0.0-20190325154230-a5d413f7728c
go: finding github.com/google/pprof v0.0.0-20181206194817-3ea8567a2e57
go: finding golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a
go: finding golang.org/x/net v0.0.0-20190311183353-d8887717615a
go: finding golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
go: finding golang.org/x/text v0.3.0
go: downloading golang.org/x/tools v0.0.0-20190325223049-1d95b17f1b04
go: extracting golang.org/x/tools v0.0.0-20190325223049-1d95b17f1b04
go run main.go -p illumos/amd64
go run main.go -p linux/mipsle
go: finding golang.org/x/crypto v0.0.0-20190325154230-a5d413f7728c
go: finding golang.org/x/arch v0.0.0-20181203225421-5a4828bb7045
go: finding golang.org/x/tools v0.0.0-20190325223049-1d95b17f1b04
go: finding github.com/ianlancetaylor/demangle v0.0.0-20180524225900-fc6590592b44
go: finding github.com/google/pprof v0.0.0-20181206194817-3ea8567a2e57
go: finding golang.org/x/sys v0.0.0-20190502175342-a43fa875dd82
go: finding golang.org/x/net v0.0.0-20190311183353-d8887717615a
go: finding golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a
go: finding golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
go: finding golang.org/x/text v0.3.0
go: downloading golang.org/x/tools v0.0.0-20190325223049-1d95b17f1b04
go: extracting golang.org/x/tools v0.0.0-20190325223049-1d95b17f1b04
go run main.go -p windows/amd64
go run main.go -p linux/386
go run main.go -p android/386
go run main.go -p plan9/amd64
go run main.go -p solaris/amd64

Investigate the firewall, and also give the vetall builder a GOPROXY.
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label May 7, 2019
@bradfitz bradfitz self-assigned this May 7, 2019
@gopherbot gopherbot added this to the Unreleased milestone May 7, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 7, 2019
@bradfitz
Copy link
Contributor Author

vetall is deleted, so closing.

@golang golang locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot