-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: downloads follow plain-HTTP redirects even when the -insecure flag is not set [1.12 backport] #31887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@bcmills Can you clarify what you meant by "a couple of weeks after the 1.13 release"? After the final 1.13 release (as in "v1.13.0" in semver form), or something else? If so, we should move this to a later 1.12.x milestone. |
After the final 1.13 release. I want folks to be able to go back to a supported 1.12 release as a mitigation if they discover a secure-to-insecure redirect when moving to 1.13. |
Moving to Go1.12.8, as 1.13 is not yet out. |
It seems that this is standing in a way of 1.12.8 release with some urgent bugfixes (eg #33405) |
@stefanb, this is not standing in the way of a release. (If it were, it would be labeled |
The point is, changing the milestone of this issue is not going to affect when the 1.12.8 release occurs. |
If we backport this fix, we should also backport CL 193259 which fixes a regression introduced in it. |
That said, I think this is too complex to backport, given the complication noted in #29591 (comment). |
(Decided not to backport; closing.) |
Per #29618 (comment):
The text was updated successfully, but these errors were encountered: