Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/vcs: adding a go-import "mod" meta tag makes RepoRootForImportPath return "unrecognized import path" error #31845

Closed
dmitshur opened this issue May 5, 2019 · 1 comment
Closed

x/tools/go/vcs: adding a go-import "mod" meta tag makes RepoRootForImportPath return "unrecognized import path" error #31845

dmitshur opened this issue May 5, 2019 · 1 comment
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented May 5, 2019 •
edited

x/tools/go/vcs is significantly behind the upstream cmd/go/internal/get code,
and has no support for modules. It continues to implement mechanics for GOPATH mode only.

However, it currently breaks when a "mod" VCS type is added. That type is meant to be backwards compatible and should apply in module mode only. This package should ignore it.

This is similar to issue #24751 (that one applied to older versions of cmd/go).
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label May 5, 2019
@dmitshur dmitshur added this to the Unreleased milestone May 5, 2019
@dmitshur dmitshur self-assigned this May 5, 2019
@gopherbot
Copy link

Change https://golang.org/cl/175219 mentions this issue: go/vcs: ignore "mod" VCS type

@dmitshur dmitshur mentioned this issue May 6, 2019
Closed
@golang golang locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot