-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: upgrade opencensus for git.apache.org problems? #31815
Comments
In the meantime, replace directive is being of great help indeed for end-projects.
|
What's this end? We're not seeing any problems, but our build system is using https://proxy.golang.org/ which has the data: https://proxy.golang.org/go.opencensus.io/@v/v0.12.0.zip And I don't even see it as a dependency of ours:
/cc @jayconrod @dmitshur |
No, x/build is not directly dependant on Problems are not always present, but sometimes they do manifest themselves and it is perfectly noticable in CI history, when As for
|
But only So what's the problem? How is this affecting you? It's not affecting us (yay caching module proxy), so what's the bug? |
Updating to It's an indirect module requirement, so it'll be a larger change and we should review the end result to make sure it doesn't introduce any problems. |
It is affecting me in my CI builds, when I am building my grpc projects in CI pipeline (no caches there).
|
Which version of It sounds like doing anything on master branch of |
It is good to know that recent cloud.google.com/go versions are not importing x/build, I could go to grpc project already indeed, not having to work all my way up before that, however I think updating opencensus dependency here would not harm too. |
FYI: updating grpc dependencies also wasn't required. grpc depends on My actual offending chain was Updating github.com/golang-migrate/migrate/v4 to v4.3.1 seem to solve my underlying issue. Still, having transitive dependencies featuring no longer officially used domain names, might be considered problematic (should any present or future project actually depend on x/build knowing what they are doing). |
Change https://golang.org/cl/175139 mentions this issue: |
x/build/go.mod seems to be depending on
go.opencensus.io@v0.18.0
which in turn depends ongit.apache.org/thrift.git
, which in turn is not always available and often misbehaves in simple re-directing togithub.com/apache/thrift
More recent opencensus (>=0.20.0) has also migrated to
github.com/apache/thrift
dependency to avoid related issues.May i suggest bumping x/build dependency to
go.opencensus.io
to avoid such issues on this end too?The text was updated successfully, but these errors were encountered: