Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: who is suppose to be congratulated? #31805

Closed
tomocy opened this issue May 2, 2019 · 1 comment
Closed

x/build/cmd/gopherbot: who is suppose to be congratulated? #31805

tomocy opened this issue May 2, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@tomocy
Copy link
Contributor

tomocy commented May 2, 2019

Does this code means as commented or not to congratulate before 2017/06/17 in UTC??
https://go.googlesource.com/build/+/refs/heads/master/cmd/gopherbot/gopherbot.go#1051
@gopherbot gopherbot added this to the Unreleased milestone May 2, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 2, 2019
@bradfitz
Copy link
Contributor

bradfitz commented May 2, 2019

The purpose was to not spam people with "Congrats!" retroactively on things that happened in the past. This was important when we first rolled out this feature of the bot.

See how that variable is used in the code below.

@bradfitz bradfitz closed this as completed May 2, 2019
@golang golang locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @gopherbot @tomocy