Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: add an example for using VerifyPeerCertificate to customize verification logic #31792

Closed
FiloSottile opened this issue May 1, 2019 · 2 comments
Closed

crypto/tls: add an example for using VerifyPeerCertificate to customize verification logic #31792

FiloSottile opened this issue May 1, 2019 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.14

Comments

@FiloSottile
Copy link
Contributor

A number of proposals to add knobs to tls.Config were closed by providing a way to achieve the same result with InsecureSkipVerify and VerifyPeerCertificate. There should be a basic example that replicates the standard verification logic, so users can edit if needed.
@FiloSottile FiloSottile added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels May 1, 2019
@FiloSottile FiloSottile added this to the Go1.13 milestone May 1, 2019
@FiloSottile FiloSottile self-assigned this May 1, 2019
@FiloSottile FiloSottile mentioned this issue May 1, 2019
Closed
@FiloSottile
Copy link
Contributor Author

FiloSottile commented May 1, 2019 •
edited

Examples:

#31791 (comment)
#28754 (comment)
#21971 (comment)
#24151 (comment)

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@gopherbot
Copy link

Change https://golang.org/cl/193620 mentions this issue: crypto/tls: add ExampleConfig_VerifyPeerCertificate

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@FiloSottile FiloSottile modified the milestones: Backlog, Go1.14 Oct 23, 2019
@golang golang locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@rsc @andybons @FiloSottile @gopherbot