New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: TestTransportMaxConnsPerHost flakes #31784
Comments
Oh, and ignore the The concerning part here is only:
|
on the plus side, I can reproduce it
|
another oddity that randomly appears when the other paases
|
Change https://golang.org/cl/175097 mentions this issue: |
Updates #31784 Change-Id: Iee056c850c03939606b227a12715c76b0339d268 Reviewed-on: https://go-review.googlesource.com/c/go/+/175097 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz I know how to make the test pass, but it is just papering over a potential issue. |
I don't see how to fix the CloseIdleConnections which would have fixed the testcase. |
I spoke too soon. We have the connection key and we can remove the host connection count. However, we really have no idea if the http2 connection is really closed or not. But we have marked the persistConn has broken regardless. |
I have a fix coming. The definition of MaxConnPerHost once you CloseIdleConnections for http/2 is not always exact but it does attempt to do the right thing. |
Change https://golang.org/cl/174950 mentions this issue: |
@cuonglm This is a different issue. Its the one I saw here #31784 (comment) |
@fraenkel do we have an issue to track it already? |
Not that I know of. |
@fraenkel I created one. |
I've seen this a few times now. @fraenkel, could you take a look?
https://storage.googleapis.com/go-build-log/b6c795d5/android-amd64-emu_95c3cb1f.log
The text was updated successfully, but these errors were encountered: