Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: os/exec: allow CommandContext termination signal to be specified #31774

Closed
caspervonb opened this issue May 1, 2019 · 5 comments
Closed
Labels
FrozenDueToAge Proposal WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@caspervonb
Copy link

caspervonb commented May 1, 2019

Currently CommandContext will send a SIGKILL which for the common case means there will likely be a dirty exit. It would be nice if we had the ability to either specify or override the kill behaviour.

This has previously been brought up in #22757 and #21135, where it was deemed as not having enough demand and would be revisited upon later.

@gopherbot gopherbot added this to the Proposal milestone May 1, 2019
@bradfitz
Copy link
Contributor

bradfitz commented May 1, 2019

Got a particular proposal? New Kill func(*os.Process) func field on exec.Cmd?

@rsc
Copy link
Contributor

rsc commented May 7, 2019

it was deemed as not having enough demand and would be revisited upon later.

We said in #22757 we'd revisit this if more evidence of demand accumulated. Can you give any information about why the demand might have gone up, or new examples of why this is important?

@andybons andybons added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 14, 2019
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@tooolbox
Copy link

Can you give any information about why the demand might have gone up, or new examples of why this is important?

Example: If the command you're executing is go run, using SIGKILL orphans the child process.

Got a particular proposal? New Kill func(*os.Process) func field on exec.Cmd?

Sounds great!

@golang golang locked and limited conversation to collaborators Jan 24, 2021
@bcmills
Copy link
Contributor

bcmills commented Jan 4, 2022

Got a particular proposal?

Can you give any information about why the demand might have gone up, or new examples of why this is important?

I've filed #50436 based on the last couple years of experience with this within the Go project. It includes links to several specific code examples within the project and links to some associated Go testing bugs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Proposal WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

7 participants