Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/api: what is contexts supposed to contain? #31725

Closed
4a6f656c opened this issue Apr 28, 2019 · 3 comments
Closed

cmd/api: what is contexts supposed to contain? #31725

4a6f656c opened this issue Apr 28, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@4a6f656c
Copy link
Contributor

The contexts list in src/cmd/api/goapi.go contains an selection of GOOS/GOARCH values, however there appears to be no consistency. There are only a subset of GOOS values and an even smaller subset of GOARCHs.

Should this be synced with cgoEnabled supported list from src/cmd/dist/build.go (which is the "single point of truth for supported platforms") or should it be pruned to remove recent additions (e.g. the incomplete netbsd/arm64 port).
@katiehockman
Copy link
Contributor

Are you suggesting a documentation change to clarify this?
For questions, see https://golang.org/wiki/Questions.

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 8, 2019
@andybons andybons added this to the Unplanned milestone May 8, 2019
@andybons
Copy link
Member

andybons commented May 8, 2019

@bradfitz

@bradfitz
Copy link
Contributor

bradfitz commented May 8, 2019

Ideally it would test all supported platforms (go tool dist list) but that's slow, so we have a representative sample that should catch most accidental mistakes.

It's true that if some files in std are tagged such that they're only for netbsd/arm64 then it's possible for API to change between releases and not be caught. But that's pretty rare that code outside runtime or syscall would be so specific to a certain port so in practice a small representative sample of ports is enough to catch mistakes.

@bradfitz bradfitz closed this as completed May 8, 2019
@golang golang locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@bradfitz @andybons @4a6f656c @gopherbot @katiehockman