Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/gopls: allow user fine-grained control over which vet checks to run #31717

Closed
inliquid opened this issue Apr 27, 2019 · 7 comments
Closed

x/tools/cmd/gopls: allow user fine-grained control over which vet checks to run #31717

inliquid opened this issue Apr 27, 2019 · 7 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@inliquid
Copy link

For example, I need to pass -composites=false flag to avoid these meaningless messages:
изображение
@gopherbot gopherbot added this to the Unreleased milestone Apr 27, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Apr 27, 2019
@stamblerre stamblerre changed the title x/tools/cmd/gopls: make embedded go vet consume additional params x/tools/cmd/gopls: allow user fine-grained control over which vet checks to run Apr 29, 2019
@stamblerre
Copy link
Contributor

/cc @ianthehat

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 28, 2019
@KatamariJr
Copy link

Any update on this? I would also like this feature for the exact same reason.

@stamblerre stamblerre added the Suggested Issues that may be good for new contributors looking for work to do. label May 31, 2019
@stamblerre
Copy link
Contributor

This hasn't been a high priority issue for us yet, but if someone wants to take a look at adding it before I have a chance to, we'd be happy to take contributions.

@guiguan
Copy link

guiguan commented Jun 1, 2019

I think this is pretty critical to the developer experience of gopls. I wish I had time to make a contribution

@gopherbot
Copy link

Change https://golang.org/cl/179920 mentions this issue: internal/lsp: allow fine-grained control over vet checks

@guiguan
Copy link

guiguan commented Jun 5, 2019

A simple workaround to config vet. For example, disable the composite analyzer for github.com/mongodb/mongo-go-driver: guiguan/tools@a9ca269

@muirdm muirdm mentioned this issue Jun 25, 2019
Open
@inliquid inliquid mentioned this issue Sep 11, 2019
Closed
@golang golang locked and limited conversation to collaborators Jun 9, 2020
@mvdan
Copy link
Member

mvdan commented Jan 24, 2021

For those of you disabling the entire composites check, would #43864 seem like a good compromise to not disable the check entirely? Please upvote that proposal or comment on it, depending on your thoughts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
7 participants
@guiguan @mvdan @KatamariJr @stamblerre @julieqiu @inliquid @gopherbot