New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: examples need improvement #31716
Labels
Milestone
Comments
FiloSottile
added
the
NeedsFix
The path to resolution is known, but the work has not been done.
label
Apr 27, 2019
@FiloSottile Can I take a look at this issue? |
Change https://golang.org/cl/175257 mentions this issue: |
Change https://golang.org/cl/179737 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jun 3, 2019
The example in example_test.go requires that the whole file be displayed; the addition of ExampleAs meant that only the body of the package example function was shown, rather than the surrounding context. This change moves ExampleAs to the file wrap_test.go file, restoring the package example to its former glory. Update #31716 Change-Id: Id0ea77bc06023b239a63c1d6a7c8b3c1dae91ce9 Reviewed-on: https://go-review.googlesource.com/c/go/+/179737 Reviewed-by: Marcel van Lohuizen <mpvl@golang.org> Reviewed-by: Jean de Klerk <deklerk@google.com> Run-TryBot: Benny Siegert <bsiegert@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Change https://golang.org/cl/228038 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Apr 13, 2020
Add ExampleIs to illustrate how errors.Is works. Updates #31716. Updates #38369. Change-Id: I1b9a6667614635aa3a5ed8b2c108d8eb6f35748b Reviewed-on: https://go-review.googlesource.com/c/go/+/228038 Reviewed-by: Damien Neil <dneil@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
There is a total of 4 examples in the package. Two are for
New
, one doesn't use the package at all, and one incorrectly usesAs
by dropping the error on the floor if it's not aos.PathError
.The text was updated successfully, but these errors were encountered: