Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: treap implementation of find() doesn't return the best-fit span [1.12 backport] #31677

Closed
gopherbot opened this issue Apr 25, 2019 · 2 comments
Closed

runtime: treap implementation of find() doesn't return the best-fit span [1.12 backport] #31677

gopherbot opened this issue Apr 25, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.5

Comments

@gopherbot
Copy link

@mknyszek requested issue #31616 to be considered for backport to the next 1.12 minor release.

@gopherbot please open a backport to 1.12. The VSS growth problem has been bad enough that it's prevented some users from being able to move to 1.12, since some of the heap metadata grows proportionally with the amount of mapped memory.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 25, 2019
@gopherbot gopherbot mentioned this issue Apr 25, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.5 milestone Apr 25, 2019
@bradfitz bradfitz added the CherryPickApproved Used during the release process for point releases label Apr 25, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 25, 2019
@mknyszek mknyszek self-assigned this Apr 25, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/173939 mentions this issue: runtime: make mTreap.find actually find the best fit

@gopherbot
Copy link
Author

Closed by merging 438b1a5 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Apr 26, 2019
@mknyszek @bradfitz
[release-branch.go1.12] runtime: make mTreap.find actually find the b…
438b1a5 
…est fit

This change modifies the implementation of mTreap.find to find the
best-fit span with the lowest possible base address.

Fixes #31677.

Change-Id: Ib4bda0f85d7d0590326f939a243a6e4665f37d3f
Reviewed-on: https://go-review.googlesource.com/c/go/+/173479
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
(cherry picked from commit 8c05d67)
Reviewed-on: https://go-review.googlesource.com/c/go/+/173939
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.5
Development

No branches or pull requests
3 participants
@bradfitz @mknyszek @gopherbot