Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages/packagestest: build mostly broken on Windows #31675

Closed
bradfitz opened this issue Apr 25, 2019 · 4 comments
Closed

x/tools/go/packages/packagestest: build mostly broken on Windows #31675

bradfitz opened this issue Apr 25, 2019 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bradfitz
Copy link
Contributor

The x/tools trybots are usually(?) failing on Windows with:

ok  	golang.org/x/tools/go/loader	13.435s
--- FAIL: TestReturnErrorWhenUsingNonGoFiles (0.09s)
    --- FAIL: TestReturnErrorWhenUsingNonGoFiles/Modules (0.05s)
        packages_test.go:1799: go [mod download]: exit status 1: go: golang.org/gopathb@v1.0.0: proxy URL "file://C:/Users/gopher/AppData/Local/Temp/1/TestReturnErrorWhenUsingNonGoFiles_Modules105513718/modproxy" uses file scheme with non-path elements
            
FAIL
FAIL	golang.org/x/tools/go/packages	41.030s
?   	golang.org/x/tools/go/packages/gopackages	[no test files]
--- FAIL: TestModulesExport (0.17s)
    modules_test.go:17: go [mod download]: exit status 1: go: golang.org/fake2@v1.0.0: proxy URL "file://C:/Users/gopher/AppData/Local/Temp/1/TestModulesExport123494941/modproxy" uses file scheme with non-path elements
        
FAIL
FAIL	golang.org/x/tools/go/packages/packagestest	0.448s

It's almost entirely red for Windows at:

https://build.golang.org/?repo=golang.org%2fx%2ftools

This is causing development problems for people using trybots at:

https://go-review.googlesource.com/c/tools/+/1642
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Windows NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 25, 2019
@bradfitz bradfitz added this to the Go1.13 milestone Apr 25, 2019
@gopherbot
Copy link

Change https://golang.org/cl/173499 mentions this issue: cmd/go/internal/modfetch: less restrictive file URL parsing

@gopherbot
Copy link

Change https://golang.org/cl/173918 mentions this issue: x/tools/go/packages/packagestest: fix GOPROXY file URLs for Windows

gopherbot pushed a commit to golang/tools that referenced this issue Apr 25, 2019
x/tools/go/packages/packagestest: fix GOPROXY file URLs for Windows
31fd60d 
On Windows, file URLs should look like file:///C:/foo/bar instead of
file://C:/foo/bar. In the latter case, the "C:" is parsed as the host.

Updates golang/go#31675

Change-Id: I7f75be44dd5d289de3ffdbd20a78130ed03cd233
Reviewed-on: https://go-review.googlesource.com/c/tools/+/173918
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
@jayconrod
Copy link
Contributor

This should be fixed by the two CLs above.

gopherbot pushed a commit that referenced this issue Apr 25, 2019
cmd/go/internal/modfetch: workaround file URL parsing on Windows
41d1bf0 
Remove the leading slash from GOPROXY file:// URLs.

Updates #31675

Change-Id: Id45af2a806afc3c216181c13f6bc73713b925693
Reviewed-on: https://go-review.googlesource.com/c/go/+/173499
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@jayconrod jayconrod reopened this Apr 25, 2019
@gopherbot
Copy link

Change https://golang.org/cl/173919 mentions this issue: go/packages/packagestest: fix GOPROXY file URLs for Windows

@golang golang locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
4 participants
@bradfitz @jayconrod @ianthehat @gopherbot