Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: assignReviewersToCLs fails to assign reviewers on CL 173018 #31663

Closed
dmitshur opened this issue Apr 24, 2019 · 1 comment
Closed

x/build/cmd/gopherbot: assignReviewersToCLs fails to assign reviewers on CL 173018 #31663

dmitshur opened this issue Apr 24, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Apr 24, 2019 •
edited

From gopherbot logs:

2019/04/24 20:58:01 No reviewers or cc: https://go-review.googlesource.com/c/crypto/+/173018
2019/04/24 20:58:01 Setting review on https://go-review.googlesource.com/c/crypto/+/173018: {Message: Labels:map[] Comments:map[
] Reviewers:[{Reviewer:6195@62eb7196-b449-3ce5-99f1-c037f21e1705 State:} {Reviewer:agl@golang.org State:CC}]}
2019/04/24 20:58:01 Could not set review for change "crypto~173018": HTTP status 400 Bad Request; )]}'
{
  "reviewers": {
    "6195@62eb7196-b449-3ce5-99f1-c037f21e1705": {
      "input": "6195@62eb7196-b449-3ce5-99f1-c037f21e1705",
      "error": "Account \u00276195@62eb7196-b449-3ce5-99f1-c037f21e1705\u0027 not found\n6195@62eb7196-b449-3ce5-99f1-c037f21e17
05 does not identify a registered user or group"
    },
    "agl@golang.org": {
      "input": "agl@golang.org"
    }
  },
  "error": "error adding reviewer"
}

Something's went wrong there. 6195 is a valid Gerrit account ID, it's @FiloSottile. Maybe the format wasn't right. Needs investigation.

This contributes to #28320.

/cc @FiloSottile @andybons @bradfitz
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 24, 2019
@dmitshur dmitshur added this to the Unreleased milestone Apr 24, 2019
@dmitshur
Copy link
Contributor Author

Querying the Gerrit API about this account now indicates it's inactive and has no email:

$ curl https://go-review.googlesource.com/accounts/6195 | tail -1 | jsonfmt
{
	"_account_id": 6195,
	[...]
	"inactive": true
}

So it's expected not to work (at least now), and maybe gopherbot was using some old cached data trying to assign it as a reviewer (and rightfully failing).

This problem isn't happening anymore, so closing.

@golang golang locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot