Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/gopls: support runtime configuration of WorkspaceFolders #31635

Closed
myitcv opened this issue Apr 23, 2019 · 1 comment
Closed

x/tools/cmd/gopls: support runtime configuration of WorkspaceFolders #31635

myitcv opened this issue Apr 23, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Milestone
Unreleased

Comments

@myitcv
Copy link
Member

myitcv commented Apr 23, 2019

Per Slack exchange with @ianthehat

Multiple workspace folders are supported at init time (https://github.com/golang/tools/blob/fe54fb35175bb1c0c175e2335e23d7fa90ca987a/internal/lsp/general.go#L55-L73) but support for the client notifying the server that the set of workspace folders has changed "during runtime" is pending (https://github.com/golang/tools/blob/fe54fb35175bb1c0c175e2335e23d7fa90ca987a/internal/lsp/server.go#L113-L115)

It should be easy to fix, I just have not bothered because I was waiting for people to experiment with the multi-folder support and see if it is an approach that works for everyone.

Creating an issue to track the addition of this fix.
@myitcv myitcv added the gopls Issues related to the Go language server, gopls. label Apr 23, 2019
@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2019
@myitcv myitcv mentioned this issue Apr 23, 2019
Closed
@ianthehat ianthehat self-assigned this Apr 23, 2019
@gopherbot
Copy link

Change https://golang.org/cl/175477 mentions this issue: internal/lsp: support dynamic workspace folder changes

@ianthehat ianthehat mentioned this issue May 6, 2019
Closed
@golang golang locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianthehat @myitcv @gopherbot