Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: completion suggests shadowed variables #31621

Closed
muirdm opened this issue Apr 23, 2019 · 1 comment
Closed

x/tools/internal/lsp: completion suggests shadowed variables #31621

muirdm opened this issue Apr 23, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Milestone
Unreleased

Comments

@muirdm
Copy link

muirdm commented Apr 23, 2019

In this example I get completions for both f variables, but we should not offer completions of shadowed variables since you can't actually reference them.

f := 123
{
  f := "hi"
  f<>
}
@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Apr 24, 2019
@gopherbot
Copy link

Change https://golang.org/cl/173958 mentions this issue: internal/lsp: handle shadowed variables in lexical completions

@golang golang locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @muirdm