Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: behavior error when request doesn't have HOST header #31598

Closed
Zheaoli opened this issue Apr 21, 2019 · 2 comments
Closed

net/http: behavior error when request doesn't have HOST header #31598

Zheaoli opened this issue Apr 21, 2019 · 2 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@Zheaoli
Copy link

Zheaoli commented Apr 21, 2019

Host header may not exist when some of the HTTP library make a request.

https://github.com/golang/go/blob/master/src/net/http/server.go#L982

In net/http, the default code forbade this request.

I think maybe raise warning info is a better idea than this.
@davecheney
Copy link
Contributor

HTTP/1.1 mandates the Host header MUST (RFC2119) be present.

Which HTTP libraries are sending malformed requests?

@davecheney davecheney added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Apr 22, 2019
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davecheney @Zheaoli @gopherbot