Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: share cache between views #31589

Closed
stamblerre opened this issue Apr 20, 2019 · 2 comments
Closed

x/tools/gopls: share cache between views #31589

stamblerre opened this issue Apr 20, 2019 · 2 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. ToolSpeed
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

Context: microsoft/vscode-go#2450
@gopherbot gopherbot added this to the Unreleased milestone Apr 20, 2019
@stamblerre stamblerre mentioned this issue Apr 20, 2019
Closed
@ianthehat ianthehat added FeatureRequest Issues asking for a new feature that does not need a proposal. gopls Issues related to the Go language server, gopls. labels Apr 21, 2019
@ianthehat
Copy link

I was looking at this the other day, in the context of wanting to improve the client server support, mostly for command line usage.
The trouble is that you end up needing some very complicated garbage collection like logic to evict things that are not needed from the cache, and you also want it to be lazy not precise, as closing a view and then immediately making a new view that wants the same information becomes a common pattern.
This means it is going to take a well thought out design.

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. ToolSpeed labels May 28, 2019
@stamblerre stamblerre changed the title x/tools/cmd/gopls: share cache between views x/tools/gopls: share cache between views Jul 2, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@stamblerre
Copy link
Contributor Author

stamblerre commented Oct 3, 2019 •
edited
Loading

I think this can be closed as of CL 198317.

@golang golang locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. ToolSpeed
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@ianthehat @bcmills @stamblerre @gopherbot