Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: modules discarded during resolution should not be added to go.sum #31580

Closed
rsc opened this issue Apr 20, 2019 · 2 comments
Closed

cmd/go: modules discarded during resolution should not be added to go.sum #31580

rsc opened this issue Apr 20, 2019 · 2 comments
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@rsc
Copy link
Contributor

rsc commented Apr 20, 2019

If I put a bad import into a program and run "go build",
then it looks in various modules for the import,
none of which work, but all of which end up in go.sum.
They should not.
@rsc rsc added this to the Go1.13 milestone Apr 20, 2019
@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 28, 2019
@julieqiu
Copy link
Member

/cc @bcmills @jayconrod

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@bcmills bcmills changed the title cmd/go: failed import resolution should not update go.sum cmd/go: modules discarded during resolution should not be added to go.sum Nov 6, 2019
@bcmills bcmills mentioned this issue Nov 6, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/237017 mentions this issue: cmd/go: don't save sums for modules loaded for import resolution

@golang golang locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@rsc @andybons @julieqiu @gopherbot @thepudds