Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: use snippets when completing composite literals #31556

Closed
muirdm opened this issue Apr 18, 2019 · 1 comment
Closed

x/tools/internal/lsp: use snippets when completing composite literals #31556

muirdm opened this issue Apr 18, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Milestone
Unreleased

Comments

@muirdm
Copy link

muirdm commented Apr 18, 2019

I think we could use snippets when completing composite literal fields. For example:

type Foo struct {
  Bar string
}

Foo{
  B<>

Could give you a snippet that does:

Foo{
  Bar: *string*,

In other words, it types the colon for you, gives you a placeholder with the type, and maybe types the comma for you as well, if it looks like multi-line literal.
@gopherbot gopherbot added this to the Unreleased milestone Apr 18, 2019
@muirdm muirdm mentioned this issue Apr 24, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/173577 mentions this issue: internal/lsp: add struct literal field snippets

@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Apr 24, 2019
@golang golang locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

internal/lsp: add struct literal field snippets muirdm/tools
2 participants
@gopherbot @muirdm