Skip to content

x/tools/go/packages: support packages entirely defined in overlays #31522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stamblerre opened this issue Apr 17, 2019 · 3 comments
Closed

x/tools/go/packages: support packages entirely defined in overlays #31522

stamblerre opened this issue Apr 17, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

From comments on https://golang.org/cl/172409:

"I think in the long run we are either going to have to have some complicated logic to associate go files with packages the same way go list would, or we are going to have to write all the overlays to a temporary directory and actually run go list on them."
@gopherbot gopherbot added this to the Unreleased milestone Apr 17, 2019
This was referenced Apr 17, 2019
Closed
Closed
Closed
This was referenced Apr 25, 2019
Closed
Merged
@myitcv myitcv mentioned this issue May 9, 2019
Closed
@w0rp w0rp mentioned this issue May 9, 2019
Closed
@myitcv myitcv mentioned this issue May 13, 2019
Closed
@bhcleek bhcleek mentioned this issue May 16, 2019
Closed
@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 28, 2019
@myitcv
Copy link
Member

myitcv commented Jul 5, 2019

@stamblerre aren't we done here now?

@stamblerre
Copy link
Contributor Author

With @matloob's changes, I believe so. Thanks for noticing this - closing now.

@matloob
Copy link
Contributor

matloob commented Jul 8, 2019

wooooooh!~

@golang golang locked and limited conversation to collaborators Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@myitcv @stamblerre @julieqiu @gopherbot @matloob