Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: new escape analysis broke s390x #31495

Closed
mdempsky opened this issue Apr 16, 2019 · 2 comments
Closed

cmd/compile: new escape analysis broke s390x #31495

mdempsky opened this issue Apr 16, 2019 · 2 comments
Labels
FrozenDueToAge

Comments

@mdempsky
Copy link
Member

The s390x builder is unhappy since I enabled newescape by default; e.g.

https://build.golang.org/log/17d8a268ff942ee3fa4fa27ea8685aaa4347b689
https://build.golang.org/log/0e2023e3028d604edf2875a48664849fd1b0b53d

I'm expecting there's a s390x-specific runtime issue (like js/wasm's https://go-review.googlesource.com/c/go/+/170323/).

I don't have access to an s390x machine at the moment, so trying to debug via looking at -m output from cross-compiling for GOARCH=s390x.

/cc @mundaym for FYI
@mdempsky mdempsky self-assigned this Apr 16, 2019
@mdempsky
Copy link
Member Author

Looks like it's the same issue: https://github.com/golang/go/blob/master/src/runtime/internal/atomic/atomic_s390x.go#L49

@gopherbot
Copy link

Change https://golang.org/cl/172417 mentions this issue: runtime/internal/atomic: fix s390x's StorepNoWB implementation

@mdempsky mdempsky mentioned this issue Apr 16, 2019
Closed
@golang golang locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot