New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context: simplify stringify with a type switch #31479

Closed

wangzhione wants to merge 1 commit into golang:master from wangzhione:patch-2

Contributor

wangzhione commented Apr 16, 2019 •

edited by bradfitz

Minor style change.


          context/context.go: update stringify

9d654de

Is it better to use switch type?

googlebot added the cla: yes label

gopherbot commented Apr 16, 2019

This PR (HEAD: 9d654de) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/172199 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Apr 16, 2019

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/172199.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 16, 2019

Message from Sameer Ajmani:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/172199.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 16, 2019

Message from Sameer Ajmani:

Patch Set 1: Run-TryBot+1

Thanks, this looks fine. Running try bots.

Please don’t reply on this GitHub thread. Visit golang.org/cl/172199.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 16, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=fcf1b60d

Please don’t reply on this GitHub thread. Visit golang.org/cl/172199.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 16, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/172199.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 16, 2019

Message from Agniva De Sarker:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/172199.
After addressing review feedback, remember to publish your drafts!

bradfitz changed the title ~~context/context.go: update stringify~~ context: simplify stringify with a type switch

gopherbot pushed a commit that referenced this pull request


          context: simplify stringify with a type switch

c4953a6

Minor style change.

Change-Id: Ib30243a71a83de1a67d3d005bfdd1e04265fca1e
GitHub-Last-Rev: 9d654de
GitHub-Pull-Request: #31479
Reviewed-on: https://go-review.googlesource.com/c/go/+/172199
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Sameer Ajmani <sameer@golang.org>

gopherbot commented Apr 16, 2019

This PR is being closed because golang.org/cl/172199 has been merged.

gopherbot closed this

itsabgr pushed a commit to itsabgr/go-ctx that referenced this pull request


          context: simplify stringify with a type switch

3ba8caa

Minor style change.

Change-Id: Ib30243a71a83de1a67d3d005bfdd1e04265fca1e
GitHub-Last-Rev: 9d654de10eaa6f01ece29790fb81bc41dfd61eaf
GitHub-Pull-Request: golang/go#31479
Reviewed-on: https://go-review.googlesource.com/c/go/+/172199
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Sameer Ajmani <sameer@golang.org>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment