Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.RemoveAll failing silently in go 1.12.2 when removing non-empty directories at / [1.12 backport] #31474

Closed
gopherbot opened this issue Apr 15, 2019 · 2 comments
Closed

os.RemoveAll failing silently in go 1.12.2 when removing non-empty directories at / [1.12 backport] #31474

gopherbot opened this issue Apr 15, 2019 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.5

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #31468 to be considered for backport to the next 1.12 minor release.

@gopherbot please open backport to 1.12
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 15, 2019
@gopherbot gopherbot mentioned this issue Apr 15, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.5 milestone Apr 15, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/172080 mentions this issue: [release-branch.go1.12] os: don't treat RemoveAll("/x") as RemoveAll("x")

@gopherbot
Copy link
Author

Closed by merging 4605817 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Apr 15, 2019
@ianlancetaylor
[release-branch.go1.12] os: don't treat RemoveAll("/x") as RemoveAll(…
4605817 
…"x")

Updates #31468
Fixes #31474

Change-Id: I5c4e61631b8af35bfc14b0cb9bc77feec100e340
Reviewed-on: https://go-review.googlesource.com/c/go/+/172058
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 3ebd952)
Reviewed-on: https://go-review.googlesource.com/c/go/+/172080
@golang golang locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.5
Development

No branches or pull requests
1 participant
@gopherbot