Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gomote: retrieve buildlet from $MOTE if present #31445

Closed
josharian opened this issue Apr 12, 2019 · 1 comment
Closed

x/build/cmd/gomote: retrieve buildlet from $MOTE if present #31445

josharian opened this issue Apr 12, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@josharian
Copy link
Contributor

I usually set a $MOTE envvar when using gomote, to minimize typing:

export MOTE=some-buildlet
gomote push $MOTE
gomote run $MOTE go/src/make.bash

I propose we hard-code this convention. All gomote commands that take a buildlet argument will check whether $MOTE is set. If so, it pretends $MOTE was provided in that argument slot. So all existing commands work unchanged as long as $MOTE is not set. If it is set, the commands above become:

export MOTE=some-buildlet
gomote push $MOTE
gomote run $MOTE go/src/make.bash

Opinions? @bradfitz @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Apr 12, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 12, 2019
@bradfitz
Copy link
Contributor

Dup of #29037 it seems. Re-open if you disagree.

@golang golang locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants