Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: <autogenerated>:1: symbol listed multiple times for same type across multiple packages [1.12 backport] #31396

Closed
gopherbot opened this issue Apr 11, 2019 · 6 comments
Closed

cmd/compile: <autogenerated>:1: symbol listed multiple times for same type across multiple packages [1.12 backport] #31396

gopherbot opened this issue Apr 11, 2019 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.5

Comments

@gopherbot
Copy link

@randall77 requested issue #31252 to be considered for backport to the next 1.11 minor release.

@gopherbot please open a backport to 1.11.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 11, 2019
@gopherbot gopherbot mentioned this issue Apr 11, 2019
Closed
@gopherbot gopherbot added this to the Go1.11.9 milestone Apr 11, 2019
@randall77
Copy link
Contributor

Whoops, wanted 1.12.

@randall77 randall77 changed the title cmd/compile: <autogenerated>:1: symbol listed multiple times for same type across multiple packages [1.11 backport] cmd/compile: <autogenerated>:1: symbol listed multiple times for same type across multiple packages [1.12 backport] Apr 11, 2019
@randall77 randall77 modified the milestones: Go1.11.9, Go1.12.4 Apr 11, 2019
@randall77 randall77 reopened this Apr 11, 2019
@randall77 randall77 self-assigned this Apr 11, 2019
@andybons andybons modified the milestones: Go1.12.4, Go1.12.5 Apr 11, 2019
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 16, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/173317 mentions this issue: cmd/compile: use correct package name for stack object symbol

@dmitshur dmitshur removed the NeedsFix The path to resolution is known, but the work has not been done. label Apr 23, 2019
@julieqiu
Copy link
Member

@randall77 - there isn't a reason provided in the gopherbot message. Would you mind providing one for this backport?

@randall77
Copy link
Contributor

This issue causes compilation to fail, and is a regression from 1.11.
Workaround is possible in some cases, but in general it is pretty hard. It might involve moving interface implementations from operating on values to operating on pointers.

@julieqiu
Copy link
Member

Thanks! Approved based on our policy at https://github.com/golang/go/wiki/MinorReleases.

@julieqiu julieqiu added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 24, 2019
gopherbot pushed a commit that referenced this issue May 6, 2019
@randall77 @andybons
[release-branch.go1.12] cmd/compile: use correct package name for sta…
a17d091 
…ck object symbol

Stack object generation code was always using the local package name
for its symbol. Normally that doesn't matter, as we usually only
compile functions in the local package. But for wrappers, the compiler
generates functions which live in other packages. When there are two
other packages with identical functions to wrap, the same name appears
twice, and the compiler goes boom.

Fixes #31396

Change-Id: I7026eebabe562cb159b8b6046cf656afd336ba25
Reviewed-on: https://go-review.googlesource.com/c/go/+/171464
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
(cherry picked from commit 43001a0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/173317
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@andybons
Copy link
Member

andybons commented May 6, 2019 •
edited

Closing since cherry-pick landed.

@andybons andybons closed this as completed May 6, 2019
@golang golang locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.5
Development

No branches or pull requests
5 participants
@andybons @dmitshur @julieqiu @randall77 @gopherbot