This PR (HEAD: f42207e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/171577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/171577.
After addressing review feedback, remember to publish your drafts!

Message from Anton Antonov:

Patch Set 1:

A bit more rationale:

Since go1.12 enhanced further the ReverseProxy implementation a closed source library (and many more open-source ones) that provide a reverse proxy for HTTP and WS can be deprecated.

The only difference between the closed source library was that I had a more convenient hook to modify a request that allowed me to focus only on the VHOST logic.

The change here would noticeably reduce the boilerplate and make developers avoid re-implementing logic and private function(s) that Directory already implements/uses.

Please don’t reply on this GitHub thread. Visit golang.org/cl/171577.
After addressing review feedback, remember to publish your drafts!

Message from Anton Antonov:

Patch Set 1: Code-Review+1

Patch Set 1:

A bit more rationale:

Since go1.12 enhanced further the ReverseProxy implementation a closed source library (and many more open-source ones) that provide a reverse proxy for HTTP and WS can be deprecated.

The only difference between the closed source library was that I had a more convenient hook to modify a request that allowed me to focus only on the VHOST logic.

The change here would noticeably reduce the boilerplate and make developers avoid re-implementing logic and private function(s) that Directory already implements/uses.

Please don’t reply on this GitHub thread. Visit golang.org/cl/171577.
After addressing review feedback, remember to publish your drafts!

Message from Agniva De Sarker:

Patch Set 1:

Patch Set 1:

A bit more rationale:

Since go1.12 enhanced further the ReverseProxy implementation a closed source library (and many more open-source ones) that provide a reverse proxy for HTTP and WS can be deprecated.

The only difference between the closed source library was that I had a more convenient hook to modify a request that allowed me to focus only on the VHOST logic.

The change here would noticeably reduce the boilerplate and make developers avoid re-implementing logic and private function(s) that Directory already implements/uses.

Hi Anton, please open an issue on github so that we can discuss this further. Any public API addition should have an attached issue with it, and be approved before we can start looking into the implementation.

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/171577.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: 7311c0f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/171577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info