Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp: generated files not marked with "// Code generated" comments #31375

Closed
gmwxio opened this issue Apr 10, 2019 · 3 comments
Closed
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gmwxio
Copy link

gmwxio commented Apr 10, 2019

Much of the code in protocol is unidiomatic. Starts making more sense in the context of generated code.

Please decorate generated code with the standard comment.

@gopherbot gopherbot added this to the Unreleased milestone Apr 10, 2019
@gmwxio
Copy link
Author

gmwxio commented Apr 10, 2019

eg

// Code generated by go.ts DO NOT EDIT.
// source:   /vscode-languageserver-node/protocol/src/protocol.ts, /vscode-languageserver-node/types/src/main.ts
// commit: 54f6caacea8aa0cf9f45527153d993010c1cc793
// tag: n/a

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 10, 2019
@bcmills bcmills changed the title x/tools/lsp: "// Code generated" in generated files eg tsprotocol.go x/tools/lsp: generated files not marked with "// Code generated" comments Apr 10, 2019
@dmitshur dmitshur changed the title x/tools/lsp: generated files not marked with "// Code generated" comments x/tools/internal/lsp: generated files not marked with "// Code generated" comments Apr 10, 2019
@stamblerre stamblerre added the gopls Issues related to the Go language server, gopls. label Apr 15, 2019
@pjweinb
Copy link

pjweinb commented May 6, 2019

Yup. Now there are 3 generated files, and they all need DO NOT EDIT.

Coming within a week.

@gopherbot
Copy link

Change https://golang.org/cl/176921 mentions this issue: internal/lsp: respond to shutdown requests and add DO NOT EDITs

@golang golang locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants