Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: add WSAECONNREFUSED #31360

Closed
mstoykov opened this issue Apr 9, 2019 · 3 comments
Closed

x/sys/windows: add WSAECONNREFUSED #31360

mstoykov opened this issue Apr 9, 2019 · 3 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@mstoykov
Copy link

mstoykov commented Apr 9, 2019

The title says it all the current value I am getting is 10061 for the errno.
@agnivade agnivade changed the title Add WSAECONNREFUSED to x/sys/windows x/sys/windows: add WSAECONNREFUSED Apr 9, 2019
@gopherbot gopherbot added this to the Unreleased milestone Apr 9, 2019
@agnivade
Copy link
Contributor

agnivade commented Apr 9, 2019

@tklauser

@bradfitz
Copy link
Contributor

bradfitz commented Apr 9, 2019

https://go-review.googlesource.com/c/sys/+/170918 addresses this, and 6,800 other ones.

@gopherbot
Copy link

Change https://golang.org/cl/170918 mentions this issue: windows: add missing error constants

@mstoykov mstoykov mentioned this issue Apr 10, 2019
Merged
mstoykov added a commit to grafana/k6 that referenced this issue Apr 10, 2019
@mstoykov
Add a todo to move to x/sys after golang/go#31360
b76ced8
mstoykov added a commit to grafana/k6 that referenced this issue Apr 10, 2019
@mstoykov
Bugfix/correctly catch connection refused on dial (#998)
4894b66 
Apparently on windows 10061(WSAECONNREFUSED) is some other
ECONNREFUSED  like errno but unfortunately it is not a
value anywhere in `syscall` or `x/sys/windows` [1]

Also add specific non application error code for unknown errno dial errors

[1] golang/go#31360
@bcmills bcmills added FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 10, 2019
srguglielmo pushed a commit to srguglielmo/k6 that referenced this issue Nov 3, 2019
@mstoykov @srguglielmo
Bugfix/correctly catch connection refused on dial (grafana#998)
168b819 
Apparently on windows 10061(WSAECONNREFUSED) is some other
ECONNREFUSED  like errno but unfortunately it is not a
value anywhere in `syscall` or `x/sys/windows` [1]

Also add specific non application error code for unknown errno dial errors

[1] golang/go#31360
@golang golang locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @mstoykov @agnivade @bcmills @gopherbot