Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: fake command-line-args package isn't created on windows when ad-hoc package file is missing #31344

Open
matloob opened this issue Apr 8, 2019 · 4 comments
Open

x/tools/go/packages: fake command-line-args package isn't created on windows when ad-hoc package file is missing #31344

matloob opened this issue Apr 8, 2019 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@matloob
Copy link
Contributor

matloob commented Apr 8, 2019

I haven't been able to reproduce this for go list, so I'm setting this as a go/packages bug for now.

It seems like on Windows, when doing a go list -e of an ad-hoc package where a source file doesn't exist, the fake command-line-args package that contains the error isn't created. See the comment on golang.org/x/tools/go/packages.TestErrorMissingFile.
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 10, 2019
@bcmills
Copy link
Contributor

bcmills commented Apr 10, 2019

CC @jayconrod

@bcmills
Copy link
Contributor

bcmills commented Apr 10, 2019

Is this in module mode, GOPATH mode, or both?

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/170863 mentions this issue: cmd/gopherbot: CC triaged issues to owners

@matloob matloob changed the title go/packages: fake command-line-args package isn't created on windows when ad-hoc package file is missing x/tools/go/packages: fake command-line-args package isn't created on windows when ad-hoc package file is missing Apr 23, 2019
@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2019
@matloob
Copy link
Contributor Author

matloob commented Apr 23, 2019

It looks like this is happening for both.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @seankhliao @matloob