Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/present: Origin mismatch for websocket when using HTTPS. #31328

Closed
daved opened this issue Apr 7, 2019 · 2 comments
Closed

x/tools/cmd/present: Origin mismatch for websocket when using HTTPS. #31328

daved opened this issue Apr 7, 2019 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@daved
Copy link

daved commented Apr 7, 2019

What version of Go are you using (go version)?

go version go1.12 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

linux + amd64

What did you do?

Running the present tool with -orighost=present.example.localhost and the reverse proxy ensuring all connections are secure causes the "/socket" request origin to be mismatched.

What did you expect to see?

101 Switching Protocols

What did you see instead?

403 Forbidden

Workaround

If the origin url scheme is swapped out to "https", then the "/socket" request returns 101 as desired.
@gopherbot gopherbot added this to the Unreleased milestone Apr 7, 2019
@gopherbot
Copy link

Change https://golang.org/cl/171118 mentions this issue: x/tools/cmd/present: fix origin mismatch for websocket when using HTTPS

@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 9, 2019
@gopherbot
Copy link

Change https://golang.org/cl/170863 mentions this issue: cmd/gopherbot: CC triaged issues to owners

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@golang golang locked and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@daved @ALTree @gopherbot