Skip to content

x/arch/arm64/arm64asm: TestObjdumpARM64TestDecode{GNU,Go}Syntaxdata failing at Go 1.12.3 #31305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ohir opened this issue Apr 6, 2019 · 7 comments
Closed

x/arch/arm64/arm64asm: TestObjdumpARM64TestDecode{GNU,Go}Syntaxdata failing at Go 1.12.3 #31305

ohir opened this issue Apr 6, 2019 · 7 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.12.12

Comments

@ohir
Copy link

ohir commented Apr 6, 2019

Relevant to #21506 and #23237.

Looks like a regression.
I can't recall this fail going from 1.10 to 1.11 on this staging env,
though its binutils certainly are newer than were at 1.10->1.11 testing.

I know that it is relevant to the binutils changing its output, but either tests should
account for changes in objdump or should fail with suitable message if objdump version
is not known to the tests.

$  objdump --version
GNU objdump (GNU Binutils) 2.31.1.20180828-19

$ go version
go version go1.11.1 linux/amd64
#... other releases tested
go version go1.12.2 linux/amd64


go env Output

$ go env
GOARCH="amd64"
GOBIN="/testbed/staging/bin"
GOCACHE="/testbed/staging/gocache"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/testbed/staging/user/go"
GOPROXY=""
GORACE=""
GOROOT="/testbed/staging/go"
GOTMPDIR="/testbed/staging/gotmp/"
GOTOOLDIR="/testbed/staging/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/testbed/staging/gotmp/go-build503835491=/tmp/go-build -gno-record-gcc-switches"

$ git checkout go1.12.2
$ cd src && ./all.bash


all.bash Output: 
(with 1.12.2 as bootstrap)
--- FAIL: TestObjdumpARM64TestDecodeGNUSyntaxdata (0.18s)
    ext_test.go:197: decode(9f3003d5) = "dsb #0x00", 4, want "ssbb", 4

    ext_test.go:197: decode(9f3403d5) = "dsb #0x04", 4, want "pssbb", 4

    ext_test.go:203: 4651 test cases, 933 expected mismatches, 2 failures; 56747 cases/second
    ext_test.go:204: decoder coverage: 96.4%;
    ext_test.go:203: 4651 test cases, 0 expected mismatches, 0 failures; 54157 cases/second
    ext_test.go:204: decoder coverage: 96.4%;
--- FAIL: TestObjdumpARM64TestDecodeGoSyntaxdata (0.12s)
    ext_test.go:197: decode(9f3003d5) = "dsb #0x00", 4, want "ssbb", 4

    ext_test.go:197: decode(9f3403d5) = "dsb #0x04", 4, want "pssbb", 4

    ext_test.go:203: 4564 test cases, 964 expected mismatches, 2 failures; 62673 cases/second
    ext_test.go:204: decoder coverage: 96.4%;
    ext_test.go:203: 4564 test cases, 0 expected mismatches, 0 failures; 62482 cases/second
    ext_test.go:204: decoder coverage: 96.4%;
FAIL
FAIL    cmd/vendor/golang.org/x/arch/arm64/arm64asm 2.087s

FAIL: cmd/vendor/golang.org/x/arch/arm64/arm64asm
@ohir
Copy link
Author

ohir commented Apr 10, 2019

Tested on 1.12.3 built with 1.12.2 bootstrap.

go version go1.12.3 linux/amd64
git checkout go1.12.3
go test cmd/vendor/golang.org/x/arch/arm64/arm64asm

--- FAIL: TestObjdumpARM64TestDecodeGNUSyntaxdata
--- FAIL: TestObjdumpARM64TestDecodeGoSyntaxdata
both pieces fail at:
    ext_test.go:197: decode(9f3003d5) = "dsb #0x00", 4, want "ssbb", 4
    ext_test.go:197: decode(9f3403d5) = "dsb #0x04", 4, want "pssbb", 4

@bcmills bcmills changed the title go1.12.2 test FAIL at cmd/vendor/golang.org/x/arch/arm64/arm64asm x/arch/arm64/arm64asm: TestObjdumpARM64TestDecode{GNU,Go}Syntaxdata failing at Go 1.12.3 Apr 10, 2019
@gopherbot gopherbot added this to the Unreleased milestone Apr 10, 2019
@bcmills
Copy link
Contributor

bcmills commented Apr 10, 2019

CC @zhangfannie @cherrymui @mwhudson via git blame.

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 10, 2019
@bcmills bcmills modified the milestones: Unreleased, Go1.13 Apr 10, 2019
@bcmills
Copy link
Contributor

bcmills commented Apr 10, 2019

Any idea why this isn't showing up as a failure on the build dashboard?

(https://build.golang.org/?branch=release-branch.go1.12)

@mwhudson
Copy link
Contributor

I fixed this in x/arch (https://go.googlesource.com/arch/+/b19384d3c130858bb31a343ea8fce26be71b5998) but it doesn't look to me as if that fix is in release-branch.go1.12.

@cherrymui
Copy link
Member

Any idea why this isn't showing up as a failure on the build dashboard?

This test is very sensitive to the GNU objdump installed on the machine. It may pass if the builder has a different version.

@mwhudson mwhudson reopened this Apr 10, 2019
@cherrymui
Copy link
Member

Thanks @mwhudson. The vendored copy of x/arch/arm64 in the standard library is older. We just need to revendor it.

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/200057 mentions this issue: [release-branch.go1.12] cmd/vendor/golang.org/x/arch/arm64/arm64asm: recognise new ssbb/pssbb mnemonics from objdump

@bcmills bcmills modified the milestones: Go1.14, Go1.12.11 Oct 9, 2019
@bcmills bcmills added the CherryPickCandidate Used during the release process for point releases label Oct 9, 2019
@toothrot toothrot added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 9, 2019
gopherbot pushed a commit that referenced this issue Oct 9, 2019
[release-branch.go1.12] cmd/vendor/golang.org/x/arch/arm64/arm64asm: …
dec07f3 
…recognise new ssbb/pssbb mnemonics from objdump

This patches in CL 136455 from the 'arch' repo.

Commands run:
~/go/src/cmd$ GOPATH=$(../../bin/go env GOROOT) govendor fetch golang.org/x/arch/arm64/arm64asm@b19384d3c130858bb31a343ea8fce26be71b5998

Updates #27754
Fixes #31305

Change-Id: I8fcc3bc3c718cf0d93afbd1d383df48316b522d4
Reviewed-on: https://go-review.googlesource.com/136455
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/200057
Run-TryBot: Bryan C. Mills <bcmills@google.com>
@bcmills bcmills closed this as completed Oct 9, 2019
@katiehockman katiehockman modified the milestones: Go1.12.11, Go1.12.12 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.12.12
Development

No branches or pull requests
8 participants
@toothrot @andybons @mwhudson @bcmills @gopherbot @ohir @cherrymui @katiehockman