Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/gopathwalk: broken on darwin w/ readdirent: bad file descriptor #31269

Closed
bradfitz opened this issue Apr 5, 2019 · 2 comments
Closed

x/tools/internal/gopathwalk: broken on darwin w/ readdirent: bad file descriptor #31269

bradfitz opened this issue Apr 5, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.13

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Apr 5, 2019

@randall77, the "syscall: avoiding _getdirentries64 on darwin" CL also seems to have broken x/tools's gopathwalk used by goimports & various other tools:

https://build.golang.org/log/ab1733a9ba43f978acbbd4b7a94d3e4da0477113

Lots of errors, but all involving readdirent: bad file descriptor
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 5, 2019
@bradfitz bradfitz added this to the Go1.13 milestone Apr 5, 2019
@gopherbot
Copy link

Change https://golang.org/cl/170698 mentions this issue: syscall: dup the argument to fdopendir

@gopherbot
Copy link

Change https://golang.org/cl/170892 mentions this issue: syscall: use openat instead of dup to make a really new file descriptor

gopherbot pushed a commit that referenced this issue Apr 5, 2019
@randall77
syscall: use openat instead of dup to make a really new file descriptor
06cff11 
Update #31269

Change-Id: I0e7184420055b8dfd23688dab9f9d8cba1fa2485
Reviewed-on: https://go-review.googlesource.com/c/go/+/170892
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
3 participants
@bradfitz @randall77 @gopherbot