Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/ssa: TestNexting broken on longtest builder #31263

Closed
bcmills opened this issue Apr 4, 2019 · 8 comments
Closed

cmd/compile/internal/ssa: TestNexting broken on longtest builder #31263

bcmills opened this issue Apr 4, 2019 · 8 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 4, 2019

https://build.golang.org/log/accd72f95cd2dcfb4da4bee9029543f35d626fd1:

--- FAIL: TestNexting (14.26s)
    --- FAIL: TestNexting/gdb-dbg-i22558 (0.97s)
        debug_test.go:242: step/next histories differ, diff=
            --- testdata/i22558.gdb-dbg.nexts	2019-04-03 21:27:05.000000000 +0000
            +++ /workdir/tmp/debug_test870531445/test-i22558.gdb-dbg.nexts	2019-04-03 21:53:20.820874734 +0000
            @@ -2,10 +2,3 @@
             19:	func test(t *thing, u *thing) {
             20:		if t.next != nil {
             23:		fmt.Fprintf(os.Stderr, "%s\n", t.name)
            -24:		u.self = u
            -25:		t.self = t
            -26:		t.next = u
            -27:		for _, p := range t.stuff {
            -28:			if isFoo(t, p) {
            -29:				return
            -44:	}

The first failure is at https://golang.org/cl/168479, but https://golang.org/cl/170639 seems like a more likely culprit. (CC @randall77 for both.)
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. labels Apr 4, 2019
@bcmills bcmills added this to the Go1.13 milestone Apr 4, 2019
@randall77
Copy link
Contributor

@dr2chase
I don't see how either of those changelists would affect this test.

@bcmills
Copy link
Contributor Author

bcmills commented Apr 4, 2019

Neither do I, but there's a clear inflection point in the dashboard, and the other CLs around that point seem even less likely.

@bcmills bcmills mentioned this issue Apr 11, 2019
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Apr 11, 2019

The fact that the longtest builder is so flaky from this regression is masking other failures in the longtest builder (#31421). This needs to be fixed soon.

@bcmills bcmills added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Apr 11, 2019
@dr2chase dr2chase self-assigned this Apr 11, 2019
@bcmills bcmills mentioned this issue Apr 17, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/172423 mentions this issue: cmd/compile/internal/ssa: skip TestNexting/gdb-dbg-i22558

gopherbot pushed a commit that referenced this issue Apr 17, 2019
cmd/compile/internal/ssa: skip TestNexting/gdb-dbg-i22558
755b509 
This test fails frequently in the longtest builder, and the failures
on the build dashboard have masked two other regressions so far.
Let's skip it until it can be fixed.

Updates #31263

Change-Id: I82bae216ebc3c5fd395c27c72c196334a130af7d
Reviewed-on: https://go-review.googlesource.com/c/go/+/172423
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bcmills bcmills removed Soon This needs to be done soon. (regressions, serious bugs, outages) release-blocker labels Apr 17, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Apr 17, 2019

This test is now skipped in the builders. It should still be fixed, but is no longer quite as urgent.

@bradfitz
Copy link
Contributor

It's back, but with a different subtest:

--- FAIL: TestNexting (13.64s)
    --- FAIL: TestNexting/gdb-opt-hist (3.06s)
        debug_test.go:245: step/next histories differ, diff=

Are these important or should we skip this too?

@bradfitz bradfitz added release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 30, 2019
@bradfitz bradfitz changed the title cmd/compile/internal/ssa: TestNexting/gdb-dbg-i22558 broken on longtest builder cmd/compile/internal/ssa: TestNexting broken on longtest builder Apr 30, 2019
@dr2chase
Copy link
Contributor

dr2chase commented May 1, 2019

We skip it for now, sort it out during the freeze.
I might want to change the test to use Delve instead of gdb; it's generally less flaky and a lot easier to figure out what the debugger is doing.

@bradfitz bradfitz mentioned this issue May 1, 2019
Closed
@dr2chase
Copy link
Contributor

dr2chase commented May 9, 2019

This is probably fixed, because TestNexting now tests Delve instead of Gdb

@bcmills bcmills closed this as completed May 10, 2019
This was referenced May 10, 2019
Closed
Closed
@golang golang locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
5 participants
@bradfitz @dr2chase @bcmills @randall77 @gopherbot