x/net/http2: frequent failures in TestTransportBodyReadError_.* #31260
Comments
bradfitz
added
Testing
|
@euroelessar, you added this test in golang/net@1c5f79c for #27208. Could you look into this and help deflake the test? |
|
Also TestTransportBodyReadError_Immediately flakes: https://storage.googleapis.com/go-build-log/b23ff2c8/windows-amd64-2016_3f47b07b.log |
|
Change https://golang.org/cl/181198 mentions this issue: |
Updates golang/go#31260 Change-Id: Icf26461dc48f5f16a91a93df6aa78fec1338f51f Reviewed-on: https://go-review.googlesource.com/c/net/+/181198 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
|
This test is flaky on Plan 9 too, because behaviour of connection close during a large write is not the same as with linux. Should also be disabled for Plan 9. |
|
Change https://golang.org/cl/231877 mentions this issue: |
In x/net/http2, tests TestServer_RejectsLargeFrames and TestTransportBodyReadError_* are disabled on Windows because they fail or flake, being dependent on the behaviour of the OS network implementation when a connection is closed during a large write. The tests fail on Plan 9 for the same reason, so they should be disabled there as well. Workaround for golang/go#31260 Fixes golang/go#37321 Change-Id: Ifa1766eaa515c419fc4192126aaf796beefead0a Reviewed-on: https://go-review.googlesource.com/c/net/+/231877 Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
bcmills
changed the title
bcmills
added
release-blocker
and removed
Testing
|
Marking as release-blocker for Go 1.19 because this failure has occurred recently on several first-class ports, including (CC @neild) |
|
Looking at the recent failures, they appear to all match #44304. |
|
Duplicate of #44304 |
Updates golang/go#31260 Change-Id: Icf26461dc48f5f16a91a93df6aa78fec1338f51f Reviewed-on: https://go-review.googlesource.com/c/net/+/181198 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
In x/net/http2, tests TestServer_RejectsLargeFrames and TestTransportBodyReadError_* are disabled on Windows because they fail or flake, being dependent on the behaviour of the OS network implementation when a connection is closed during a large write. The tests fail on Plan 9 for the same reason, so they should be disabled there as well. Workaround for golang/go#31260 Fixes golang/go#37321 Change-Id: Ifa1766eaa515c419fc4192126aaf796beefead0a Reviewed-on: https://go-review.googlesource.com/c/net/+/231877 Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Saw flake on
windows-386-2008trybot run:https://storage.googleapis.com/go-build-log/bead3586/windows-386-2008_71f1676b.log
The text was updated successfully, but these errors were encountered: