Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: ensure that frozen issues still receive mentions #31257

Open
FiloSottile opened this issue Apr 4, 2019 · 3 comments
Open

x/build/cmd/gopherbot: ensure that frozen issues still receive mentions #31257

FiloSottile opened this issue Apr 4, 2019 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@FiloSottile
Copy link
Contributor

I believe this didn't use to be the case, but if a locked (FrozenDueToAge) issue is referenced by a commit or by another issue, it does not show up in the UI. That's fairly annoying, because it's nice to see what follow-up discussion or changes happened when investigating an old issue.

I don't really know what the solution is here. Complain to GitHub? They surely had to do this for anti-abuse reasons.

/cc @golang/osp-team
@FiloSottile FiloSottile added this to the Unreleased milestone Apr 4, 2019
@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 4, 2019
@bcmills
Copy link
Contributor

bcmills commented Apr 4, 2019 •
edited

I think in the past we've discussed making @gopherbot scan for (at least project-internal) mentions and ephemerally unlock the issue to pick them up.

CC @bradfitz @dmitshur @broady

@broady
Copy link
Member

broady commented Apr 12, 2019

Hm - so the API isn't as full-featured as the UI?

While a conversation is locked, only people with write access and repository owners and collaborators can add comments.

https://help.github.com/en/articles/locking-conversations

@bcmills bcmills changed the title github: locked issues don't get references x/build/cmd/gopherbot: ensure that frozen issues still receive mentions Apr 15, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/170863 mentions this issue: cmd/gopherbot: CC triaged issues to owners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@broady @andybons @FiloSottile @bcmills @gopherbot