Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/ipv6: TestIPPerInterfaceSinglePacketConnWithSingleGroupListener broken on freebsd-386 for Go 1.11 #31221

Closed
bradfitz opened this issue Apr 3, 2019 · 12 comments
Closed

x/net/ipv6: TestIPPerInterfaceSinglePacketConnWithSingleGroupListener broken on freebsd-386 for Go 1.11 #31221

bradfitz opened this issue Apr 3, 2019 · 12 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Apr 3, 2019

TestIPPerInterfaceSinglePacketConnWithSingleGroupListener is broken on freebsd-386-* with Go 1.11:

https://build.golang.org/log/7c758c236a9eff9b87a8fc6adb6013af786c2eb7

--- FAIL: TestIPPerInterfaceSinglePacketConnWithSingleGroupListener (0.00s)
    multicastlistener_test.go:247: listen ip6:ipv6-icmp 0:fe:8000::%lo0: bind: can't assign requested address
FAIL
FAIL	golang.org/x/net/ipv6	0.019s

@mikioh, can you fix?
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. OS-FreeBSD NeedsFix The path to resolution is known, but the work has not been done. labels Apr 3, 2019
@bradfitz bradfitz added this to the Unreleased milestone Apr 3, 2019
@mikioh
Copy link
Contributor

mikioh commented Apr 3, 2019

Dupe of #28826. Please backport the CLs to release-branch.go1.11 if necessary; I cannot make backport CLs.

PS: freebsd-386 builders are actually freebsd-compat32 builders.

@mikioh mikioh closed this as completed Apr 3, 2019
@mikioh
Copy link
Contributor

mikioh commented Apr 3, 2019

Please backport the CLs

CL 139577 and CL 139917.

@mikioh mikioh removed their assignment Apr 3, 2019
@bradfitz
Copy link
Contributor Author

bradfitz commented Apr 3, 2019

Re-opening the bug, as this isn't fix. The build.golang.org dashboard is still red.

@bradfitz bradfitz reopened this Apr 3, 2019
@gopherbot
Copy link

Change https://golang.org/cl/170617 mentions this issue: [release-branch.go1.11] route: re-adjust routing message alignment for FreeBSD 386 emulation

@gopherbot
Copy link

Change https://golang.org/cl/170618 mentions this issue: [release-branch.go1.11] route: don't run NET_RT_IFLIST vs. NET_RT_IFLISTL test in 386 emulation (again)

gopherbot pushed a commit to golang/net that referenced this issue Apr 3, 2019
@cixtor @bradfitz
[release-branch.go1.11] route: re-adjust routing message alignment fo…
f9f770b 
…r FreeBSD 386 emulation

On 11.2-RELEASE or above FreeBSD kernels, the breakage of routing
message alignment for 386 emulation (see COMPAT_FREEBSD32 in
sys/net/rtsock.c) is fixed. This change makes packages in the x/net
repository work regardless of the kernel fix.

Updates golang/go#31221

Change-Id: Ie71cc7dfb842c66225f96d1fb0e8cc5de7c47015
Reviewed-on: https://go-review.googlesource.com/c/139577
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 68fc911)
Reviewed-on: https://go-review.googlesource.com/c/net/+/170617
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue Apr 3, 2019
@cixtor @bradfitz
[release-branch.go1.11] route: don't run NET_RT_IFLIST vs. NET_RT_IFL…
48a9fcb 
…ISTL test in 386 emulation (again)

We are no longer able to use the kernel bug for detecting the execution
of 386 emulation on 11.2-RELEASE or above kernels. This change uses a
variable that holds the execution mode detected in init instead.

Updates golang/go#31221

Change-Id: Ib6afdbc40ae1feb8caf040c64c4b01971efc6325
Reviewed-on: https://go-review.googlesource.com/c/139917
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 146acd2)
Reviewed-on: https://go-review.googlesource.com/c/net/+/170618
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz
Copy link
Contributor Author

bradfitz commented Apr 4, 2019

That didn't seem to fix it.

@mikioh
Copy link
Contributor

mikioh commented Apr 4, 2019

As described in #28826, the dependency is: T depends on net-of-stdlib depends on vendored x/net/route-of-stdlib. Please re-vendor the x/net/route to the release-branch.go1.11 of stdlib.

@bradfitz
Copy link
Contributor Author

bradfitz commented Apr 4, 2019

Did Go 1.11 really ship not passing its tests on x/net?

@mikioh
Copy link
Contributor

mikioh commented Apr 4, 2019

I'm not sure about {build,try}bot fleet configuration. FreeBSD 11.2 kernel was released in June 2018. Perhaps the fleet was not updated during the release (or another possibility could be that I forgot to sweep the health check of the fleet because we also had the football world cup games in June-July 2018. :)

@gopherbot
Copy link

Change https://golang.org/cl/170777 mentions this issue: ipv4, ipv6: skip tests on FreeBSD prior to Go 1.12

@gopherbot
Copy link

Change https://golang.org/cl/170897 mentions this issue: ipv4, ipv6: skip tests on freebsd/386 with previous standard libraries

@gopherbot
Copy link

Change https://golang.org/cl/170782 mentions this issue: dashboard: disable more builders

@golang golang locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @mikioh @gopherbot