Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httputil: ReverseProxy FlushInterval no longer flushes headers in go1.12 [1.12 backport] #31144

Closed
gopherbot opened this issue Mar 29, 2019 · 2 comments
Closed

net/http/httputil: ReverseProxy FlushInterval no longer flushes headers in go1.12 [1.12 backport] #31144

gopherbot opened this issue Mar 29, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.2

Comments

@gopherbot
Copy link

@bradfitz requested issue #31125 to be considered for backport to the next 1.12 minor release.

@gopherbot, please backport to Go 1.12.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 29, 2019
@gopherbot gopherbot mentioned this issue Mar 29, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.2 milestone Mar 29, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/170137 mentions this issue: [release-branch.go1.12] net/http/httputil: make ReverseProxy flush headers on FlushInterval

@bradfitz bradfitz added the CherryPickApproved Used during the release process for point releases label Mar 29, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 29, 2019
@gopherbot
Copy link
Author

Closed by merging ec06e9b to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Apr 2, 2019
@liggitt @bradfitz
[release-branch.go1.12] net/http/httputil: make ReverseProxy flush he…
ec06e9b 
…aders on FlushInterval

A regression was introduced in CL 137335 (5440bfc) that caused FlushInterval
to not be honored until the first Write() call was encountered. This change
starts the flush timer as part of setting up the maxLatencyWriter.

Fixes #31144

Change-Id: I75325bd926652922219bd1457b2b00ac6d0d41b0
Reviewed-on: https://go-review.googlesource.com/c/go/+/170066
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 2cc3473)
Reviewed-on: https://go-review.googlesource.com/c/go/+/170137
@golang golang locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.2
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot