New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: document use of nested go.mod
files to prune out irrelevant directories
#31137
Comments
This is another example of a filename that fails: go: finding github.com/slimjim777/snapd/asserts latest go: finding github.com/slimjim777/snapd latest go: extracting github.com/slimjim777/snapd v0.0.0-20190329103353-c1ea86c7084a -> unzip /Users/jjesudason/go/pkg/mod/cache/download/github.com/slimjim777/snapd/@v/v0.0.0-20190329103353-c1ea86c7084a.zip: malformed file path "tests/completion/data/twisted/this isn't.innit": invalid char '\'' |
@bcmills this is coming up pretty frequently now. Shall we do something about it ? |
@agnivade We can look at specific characters, but in general we cannot allow non-portable filenames within modules. If there are parts of the repository that should not be included in the module at all, you can always cut them off by adding another |
@bcmills that's interesting - could clarify how to do that? The |
go.mod
files to prune out irrelevant directories
@slimjim777, you should be able to just drop in an empty
|
Thanks - I'll create a PR for that project. Then docs that I've found are: https://github.com/golang/go/wiki/Modules |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
github.com/snapcore/snapd
as an importgo mod tidy
What did you expect to see?
Expected to see the package fetched successfully
What did you see instead?
go modules choke on some filenames that it does not like, even though they are no Go files and have no relevance to the app/package compilation
The text was updated successfully, but these errors were encountered: