Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go directive is not only added during go mod init, but also under other conditions that are hard to deduce [1.12 backport] #31117

Closed
gopherbot opened this issue Mar 28, 2019 · 5 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #30790 to be considered for backport to the next 1.12 minor release.

@gopherbot, please backport to 1.12: the current behavior is confusing, and the fix is small

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 28, 2019
@gopherbot gopherbot added this to the Go1.12.2 milestone Mar 28, 2019
@andybons andybons modified the milestones: Go1.12.2, Go1.12.3, Go1.12.4, Go1.12.5 Apr 5, 2019
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Apr 16, 2019
@julieqiu
Copy link
Member

@bcmills @jayconrod @dmitshur - would it be considered a serious problem with no workaround?

Under our policy at https://github.com/golang/go/wiki/MinorReleases, only fixes for security issues, serious problems with no workaround, and documentation fixes will be backported.

@bcmills
Copy link
Contributor

bcmills commented Apr 30, 2019

I think this qualifies as a serious problem with no workaround: it causes the go command to add unintended go directives under circumstances that are difficult for users to predict.

@rsc
Copy link
Contributor

rsc commented Apr 30, 2019

@bcmills, why is this problem serious? I don't see it having any impact at all!

@bcmills
Copy link
Contributor

bcmills commented Apr 30, 2019

It can cause significant confusion for authors of standalone modules (that is, modules that lack any external requirements).

(That said, my notion of “significant” may differ from yours, so I won't be at all offended if the backport is declined.)

@andybons
Copy link
Member

andybons commented May 6, 2019

While confusing, this doesn't really qualify as a serious problem (programs outright breaking). Declining.

@andybons andybons closed this as completed May 6, 2019
@golang golang locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

6 participants