Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp/protocol: vet failures for json tags #31090

Closed
myitcv opened this issue Mar 27, 2019 · 2 comments
Closed

x/tools/internal/lsp/protocol: vet failures for json tags #31090

myitcv opened this issue Mar 27, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@myitcv
Copy link
Member

myitcv commented Mar 27, 2019

What version of Go are you using (go version)?

$ go version
go version devel +478f3a5384 Wed Mar 27 16:21:00 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190325223049-1d95b17f1b04

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPROXY=""
GORACE=""
GOROOT="/home/myitcv/gos"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build072271407=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version devel +478f3a5384 Wed Mar 27 16:21:00 2019 +0000 linux/amd64
GOROOT/bin/go tool compile -V: compile version devel +478f3a5384 Wed Mar 27 16:21:00 2019 +0000
uname -sr: Linux 4.15.0-46-generic
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.27-3ubuntu1) stable release version 2.27.

What did you do?

$ go vet golang.org/x/tools/internal/lsp/protocol
# golang.org/x/tools/internal/lsp/protocol
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:1023:2: struct field TextDocument repeats json tag "textDocument" also at tsprotocol.go:1012
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:1024:2: struct field TextDocument repeats json tag "textDocument" also at tsprotocol.go:1012
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:1025:2: struct field Workspace repeats json tag "workspace" also at tsprotocol.go:1007
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:1026:2: struct field Workspace repeats json tag "workspace" also at tsprotocol.go:1007
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:1027:2: struct field TextDocument repeats json tag "textDocument" also at tsprotocol.go:1012
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:1028:2: struct field TextDocument repeats json tag "textDocument" also at tsprotocol.go:1012
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:1029:2: struct field TextDocument repeats json tag "textDocument" also at tsprotocol.go:1012
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:1030:2: struct field TextDocument repeats json tag "textDocument" also at tsprotocol.go:1012
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:2321:2: struct field Kind repeats json tag "kind" also at tsprotocol.go:2291
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:2361:2: struct field Kind repeats json tag "kind" also at tsprotocol.go:2291
../../../../pkg/mod/golang.org/x/tools@v0.0.0-20190325223049-1d95b17f1b04/internal/lsp/protocol/tsprotocol.go:2406:2: struct field Kind repeats json tag "kind" also at tsprotocol.go:2291

What did you expect to see?

A clean vet run

What did you see instead?

The above failures

cc @stamblerre

@myitcv myitcv added the gopls Issues related to the Go language server, gopls. label Mar 27, 2019
@gopherbot gopherbot added this to the Unreleased milestone Mar 27, 2019
@stamblerre
Copy link
Contributor

cc @pjweinb

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 1, 2019
@stamblerre
Copy link
Contributor

This was fixed by https://golang.org/cl/171026.

@golang golang locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants