Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: provide support for alternative content markups #31078

Closed
myitcv opened this issue Mar 27, 2019 · 3 comments
Closed

x/tools/internal/lsp: provide support for alternative content markups #31078

myitcv opened this issue Mar 27, 2019 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Milestone
Unreleased

Comments

@myitcv
Copy link
Member

myitcv commented Mar 27, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.1 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190325223049-1d95b17f1b04

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN="/home/myitcv/gostuff/src/github.com/myitcv/govim/.bin"
GOCACHE="/home/myitcv/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPROXY=""
GORACE=""
GOROOT="/home/myitcv/gos"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build773545166=/tmp/go-build -gno-record-gcc-switches"

What did you do?

The result of a Hover request includes marked-up content. At the moment, markdown is the markup used.

However for terminal-based editors like Vim, this isn't very friendly.

For now I'm working around this by effectively plain-rendering the markdown.

Would it make sense to have an option somewhere to control this?
@myitcv myitcv added the gopls Issues related to the Go language server, gopls. label Mar 27, 2019
@gopherbot gopherbot added this to the Unreleased milestone Mar 27, 2019
@myitcv
Copy link
Member Author

myitcv commented Mar 27, 2019

cc @stamblerre

@myitcv
Copy link
Member Author

myitcv commented Mar 27, 2019

cc @bhcleek

@stamblerre stamblerre mentioned this issue Apr 17, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/172601 mentions this issue: internal/lsp: check content format instead of assuming markdown

@golang golang locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@myitcv @gopherbot