Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: Error when running concurrent DNS queries using cgo on MacOS [1.12 backport] #31062

Closed
gopherbot opened this issue Mar 26, 2019 · 2 comments
Closed

net: Error when running concurrent DNS queries using cgo on MacOS [1.12 backport] #31062

gopherbot opened this issue Mar 26, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.2

Comments

@gopherbot
Copy link

@mikioh requested issue #30521 to be considered for backport to the next 1.12 minor release.

@gopherbot please consider this for backport to 1.12
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 26, 2019
@gopherbot gopherbot mentioned this issue Mar 26, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.2 milestone Mar 26, 2019
@mikioh mikioh mentioned this issue Mar 27, 2019
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/170320 mentions this issue: [release-branch.go1.12] net: use network and host as singleflight key during lookupIP

@andybons andybons added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 2, 2019
gopherbot pushed a commit that referenced this issue Apr 2, 2019
@cezarsa @bradfitz
[release-branch.go1.12] net: use network and host as singleflight key…
578e281 
… during lookupIP

In CL 120215 the cgo resolver was changed to have different logic based
on the network being queried. However, the singleflight cache key wasn't
updated to also include the network. This way it was possible for
concurrent queries to return the result for the wrong network.

This CL changes the key to include both network and host, fixing the
problem.

Fixes #31062

Change-Id: I8b41b0ce1d9a02d18876c43e347654312eba22fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/166037
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit e341bae)
Reviewed-on: https://go-review.googlesource.com/c/go/+/170320
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Author

Closed by merging 578e281 to release-branch.go1.12.

@golang golang locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.2
Development

No branches or pull requests
2 participants
@andybons @gopherbot