Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie value can't contains "=" character. #31029

Closed
butnet opened this issue Mar 25, 2019 · 3 comments
Closed

cookie value can't contains "=" character. #31029

butnet opened this issue Mar 25, 2019 · 3 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@butnet
Copy link

butnet commented Mar 25, 2019 •
edited

go/src/net/http/cookie.go

Line 359 in 68a98d5

if strings.IndexByte(v, ' ') >= 0 || strings.IndexByte(v, ',') >= 0 {

I change to
if strings.IndexByte(v, ' ') >= 0 || strings.IndexByte(v, ',') >= 0 || strings.IndexByte(v, '=') >= 0 {
@agnivade
Copy link
Contributor

agnivade commented Mar 25, 2019 •
edited

Please fill the complete issue template, mentioning what you did, what you saw and what you expected. A self-contained code sample which shows the issue is preferred.

@agnivade agnivade added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Mar 26, 2019
@vdobler
Copy link
Contributor

vdobler commented Apr 9, 2019

According to https://tools.ietf.org/html/rfc6265#section-4.1.1 the cookie-value consists of cookie-octets which do allow 0x3d '=' (covered by the range %x3C-5B). Also all browsers accept = signs in cookie values. Quoting a cookie-value containing a '=' is not necessary.

What is this issue addressing?

@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vdobler @agnivade @butnet @gopherbot