Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.12.1 dsymutil segmentation fault on MacOS Sierra [1.12 backport] #31028

Closed
gopherbot opened this issue Mar 25, 2019 · 2 comments
Closed

Go 1.12.1 dsymutil segmentation fault on MacOS Sierra [1.12 backport] #31028

gopherbot opened this issue Mar 25, 2019 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.2

Comments

@gopherbot
Copy link

@benesch requested issue #30908 to be considered for backport to the next 1.12 minor release.

Thanks, @thanm. Nominating this for backport since it prevents Homebrew from packaging any Go software that happens to trigger this invalid DWARF generation.

@gopherbot please consider this for backport to 1.12; it's a serious toolchain bug.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 25, 2019
@gopherbot gopherbot mentioned this issue Mar 25, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.2 milestone Mar 25, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/169417 mentions this issue: [release-branch.go1.12] cmd/compile: better handling for PAUTOHEAP in DWARF inline gen

@gopherbot
Copy link
Author

Closed by merging e552f77 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Mar 27, 2019
@thanm @ianlancetaylor
[release-branch.go1.12] cmd/compile: better handling for PAUTOHEAP in…
e552f77 
… DWARF inline gen

When generating DWARF inline info records, the post-SSA code looks
through the original "pre-inline" dcl list for the function so as to
handle situations where formal params are promoted or optimized away.
This code was not properly handling the case where an output parameter
was promoted to the heap -- in this case the param node is converted
in place from class PPARAMOUT to class PAUTOHEAP. This caused
inconsistencies later on, since the variable entry in the abstract
subprogram DIE wound up as a local and not an output parameter.

Updates #30908.
Fixes #31028.

Change-Id: Ia70b89f0cf7f9b16246d95df17ad6e307228b8c7
Reviewed-on: https://go-review.googlesource.com/c/go/+/168818
Reviewed-by: Cherry Zhang <cherryyz@google.com>
(cherry picked from commit 68a98d5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/169417
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.2
Development

No branches or pull requests
1 participant
@gopherbot