New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: expose Writer() method of the standard logger #31009
Conversation
The Go 1.12 introduced Writer() method for logger objects, but it was not exposed as log package function for standard logger. This commit adds such Writer() function.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLA signed! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: dc152ea) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/168920 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/168920. |
Message from Rob Pike: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/168920. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=a6acdd22 Please don’t reply on this GitHub thread. Visit golang.org/cl/168920. |
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/168920. |
Message from Rob Pike: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/168920. |
The Go 1.12 introduced Writer() method for logger objects, but it was not exposed as log package function for standard logger. This commit adds such Writer() function. Change-Id: Ia81b1524839fe05c152ecb5eaef047a076349fea GitHub-Last-Rev: dc152ea GitHub-Pull-Request: #31009 Reviewed-on: https://go-review.googlesource.com/c/go/+/168920 Run-TryBot: Rob Pike <r@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
This PR is being closed because golang.org/cl/168920 has been merged. |
The Go 1.12 introduced Writer() method for logger objects, but
it was not exposed as log package function for standard logger.
This commit adds such Writer() function.