-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: miscompilation of codependent global var
assigments in go1.12 [1.12 backport]
#30996
Comments
Change https://golang.org/cl/168817 mentions this issue: |
var
assigments in go1.12 [1.12 backport]var
assigments in go1.12 [1.12 backport]
@randall77 I saw you reviewed https://golang.org/cl/168817 - does that mean this should be labeled |
No, that's still a call for the release guys to make. Feel free to add pro-backport arguments to this issue. |
Thanks for explaining (and apologies for being a bit noisy 🤗) For our next release, this one is definitely a show-stopper, as the result is unpredictable. Timing is a bit unfortunate as we'll have to decide to proceed with Go 1.12, or revert all repositories to Go 1.11. @bradfitz (I saw you applied the labels on other issues; so hope you're the right person to ask); ptal |
For my information; Is there any documentation about the Go release procedure? (or a mailinglist / meeting people can attend to stay informed?) |
Awesome, thanks! |
Closed by merging 8acc2ea to release-branch.go1.12. |
…ting write barrier call It is possible that a "volatile" value (one that can be clobbered by preparing args of a call) to be used in multiple write barrier calls. We used to copy the volatile value right before each call. But this doesn't work if the value is used the second time, after the first call where it is already clobbered. Copy it before emitting any call. Updates #30977. Fixes #30996. Change-Id: Iedcc91ad848d5ded547bf37a8359c125d32e994c Reviewed-on: https://go-review.googlesource.com/c/go/+/168677 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org> (cherry picked from commit f23c601) Reviewed-on: https://go-review.googlesource.com/c/go/+/168817 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@cherrymui requested issue #30977 to be considered for backport to the next 1.12 minor release.
The text was updated successfully, but these errors were encountered: